Replace set() by dict comprehension in recipients for new comments #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maudetes
changed the title
quaxsze
approved these changes
Aug 29, 2023
maudetes
commented
Aug 29, 2023
| @@ -550,3 +551,76 @@ def test_notify_org_discussions(self): | |||
| self.assertEqual(details['title'], discussion.title) | |||
| self.assertEqual(details['subject']['id'], discussion.subject.id) | |||
| self.assertEqual(details['subject']['type'], 'dataset') | |||
|
|
|||
|
|
|||
| class DiscussionsMailsTest(APITestCase): | |||
There was a problem hiding this comment.
Mostly copied from udata-front
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Member of an organization that have taken part in a discussion on one of its documents are notified twice by mail about a new comment.
Indeed,
set(recipients)does not work as expected, probably because it uses__hash__, that should be defined based on primary key, but is overridden in the context of UserMixin.We're replacing it by a dict comprehension on user.id to make sure we have only one occurrence of each user.
See https://mattermost.incubateur.net/betagouv/pl/q91rpukpatna9jfbryiafqq7rw for context.