Fix site title and keywords never get updated #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maudetes
reviewed
Oct 10, 2023
udata/core/site/models.py
Outdated
| }) | ||
| if not created: | ||
| Site.objects(id=site_id).modify(set__title=site_title, set__keywords=site_keywords) |
There was a problem hiding this comment.
This would imply a modification every time with access current_site, which may be overkill.
Instead of using a not created as condition which will be true most of the time, would it be more efficient to compare if g.site.keyword != site_keyword and same with title?
There was a problem hiding this comment.
True, I somehow thought that it won't be called every time.
…er-updated # Conflicts: # CHANGELOG.md
maudetes
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently changing
SITE_TITLEand/orSITE_KEYWORDSsettings doesn't have any effect as initial values stored in Mongo are taken. I'm not sure if this was done intentionally, but in my opinion such update might be needed every now and then, at least for keywords.Note:
upsertoption could've been used inmodify()to do everything in a single line but unfortunately this method doesn't seem to return the object. Maybe there's still a more elegant way that I'm overlooking.