Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topics are now db.Owned and filter is by ID #2901

Merged
merged 7 commits into from Oct 6, 2023
Merged

Topics are now db.Owned and filter is by ID #2901

merged 7 commits into from Oct 6, 2023

Conversation

quaxsze
Copy link
Collaborator

@quaxsze quaxsze commented Oct 5, 2023 •
edited

@quaxsze
Copy link
Collaborator Author

quaxsze commented Oct 5, 2023

No migration is needed as topics already had an owner referenceField.
Reindex is needed to index the ids instead of the slugs

@quaxsze quaxsze requested a review from maudetes October 5, 2023 22:21
maudetes
maudetes reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work quite easily, well done :)

Could you maybe add a test on topic creation as an organization (probably similar to tests for reuse)?

udata/core/dataset/search.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
quaxsze and others added 2 commits October 6, 2023 12:05
@quaxsze @maudetes
Update udata/core/dataset/search.py
64c6fb5 
Co-authored-by: maudetes <maudet.estelle@gmail.com>
@quaxsze
add test
ff74fbb
@quaxsze quaxsze requested a review from maudetes October 6, 2023 10:29
maudetes
maudetes approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

udata/tests/api/test_topics_api.py Outdated Show resolved Hide resolved
@quaxsze @maudetes
Update udata/tests/api/test_topics_api.py
ff750d8 
Co-authored-by: maudetes <maudet.estelle@gmail.com>
@quaxsze quaxsze merged commit a9633f4 into master Oct 6, 2023
1 check passed
@quaxsze quaxsze deleted the topicsImprovements branch October 6, 2023 10:47
@maudetes maudetes mentioned this pull request Oct 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maudetes maudetes maudetes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@quaxsze @maudetes