Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topics upgrades : add a created_at field and allow to filter on tags or name #2904

Merged
merged 12 commits into from Oct 17, 2023
Merged

Topics upgrades : add a created_at field and allow to filter on tags or name #2904

merged 12 commits into from Oct 17, 2023

Conversation

quaxsze
Copy link
Contributor

@quaxsze quaxsze commented Oct 10, 2023 •
edited

@quaxsze quaxsze requested a review from maudetes October 10, 2023 13:37
maudetes
maudetes reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! Could you add tests on new filters and remove all datasets bugs please? 🙏

udata/core/topic/models.py Show resolved Hide resolved
udata/forms/fields.py Outdated Show resolved Hide resolved
@quaxsze quaxsze requested a review from maudetes October 10, 2023 14:19
@maudetes maudetes mentioned this pull request Oct 12, 2023
Closed
maudetes
maudetes reviewed Oct 13, 2023
View reviewed changes
udata/forms/fields.py Outdated Show resolved Hide resolved
@quaxsze quaxsze requested a review from maudetes October 16, 2023 13:21
maudetes
maudetes approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@maudetes maudetes changed the title Topics bug fixes Topics upgrades : add a created_at field and allow to filter on tags or name Oct 16, 2023
@quaxsze quaxsze merged commit d324409 into master Oct 17, 2023
1 check passed
@quaxsze quaxsze deleted the topicsFix branch October 17, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maudetes maudetes maudetes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topic: filter by extras or tag value
2 participants
@quaxsze @maudetes