Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oauth): allow wildcards in redirect_uris #2935

Merged
merged 3 commits into from Dec 11, 2023

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Dec 5, 2023

This add a setting and logic to allow wildcards in redirect_uris for an OAuth2Client.

On Ecosphères, it will be very useful to be able to use OAuth when testing PR previews that have URLs like https://deploy-preview-205--ecospheres.netlify.app. We could authorize *ecospheres.netlify.app/login/callback for our client.

Since this might be dangerous security-wise, it's behind a flag that is False by default. I suggest enabling it only on dev/demo instances and not in production.

Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Seems secure enough with default flag indeed.

Since it's a hassle to test it correctly locally, if you update the branch I can deploy it on our demo env before merging :)

@abulte
Copy link
Contributor Author

abulte commented Dec 8, 2023

@maudetes updated! FYI I tested locally with a *.local pattern and ecospheres-front, but it never hurts to check again.

@maudetes maudetes merged commit 5b6f01c into opendatateam:master Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants