Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reuses and datasets with no private attribute #2951

Merged
merged 8 commits into from Feb 7, 2024
Merged

Fix reuses and datasets with no private attribute #2951

merged 8 commits into from Feb 7, 2024

Conversation

ThibaudDauce
Copy link
Contributor

@ThibaudDauce ThibaudDauce commented Jan 29, 2024 •
edited

@ThibaudDauce ThibaudDauce force-pushed the fix_reuse_with_no_private_attribute branch from c83762f to 731fdd4 Compare January 29, 2024 09:08
maudetes
maudetes reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Don't forget the changelog ;)
I'm wondering if we can have the same issue with Datasets?

@ThibaudDauce ThibaudDauce changed the title Fix reuse with no private attribute Fix reuses and datasets with no private attribute Jan 29, 2024
maudetes
maudetes reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

I think the migration doesn't work as is due to mongoengine Document logic.

udata/migrations/2024-01-29-fix-reuse-and-dataset-with-private-None.py Outdated Show resolved Hide resolved
udata/migrations/2024-01-29-fix-reuse-and-dataset-with-private-None.py Outdated Show resolved Hide resolved
maudetes
maudetes approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

udata/migrations/2024-01-29-fix-reuse-and-dataset-with-private-None.py Outdated Show resolved Hide resolved
@ThibaudDauce @maudetes
Update udata/migrations/2024-01-29-fix-reuse-and-dataset-with-private…
7c65ef0 
…-None.py

Co-authored-by: maudetes <maudet.estelle@gmail.com>
@ThibaudDauce ThibaudDauce merged commit cda9af2 into master Feb 7, 2024
1 check passed
@maudetes maudetes deleted the fix_reuse_with_no_private_attribute branch February 16, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maudetes maudetes maudetes approved these changes

Assignees

@maudetes maudetes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rajouter les réutilisations manquantes sur l'export csv du catalogue des reuses
2 participants
@ThibaudDauce @maudetes