New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved spam prevention #2954
Improved spam prevention #2954
Conversation
bb9f941
to
bd320ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A WIP review :)
I quite like the SpamMixin pattern.
Not sure I have the entire callbacks logic in mind, I'll need to re-read this part.
We may want to filter on discussions_notifications
as well?
0203a33
to
ce0d383
Compare
2379b7e
to
f739d9d
Compare
e4ad0e7
to
0a4a91a
Compare
Co-authored-by: maudetes <maudet.estelle@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you for this PR and the latest iterations!
I mark as approved as I have only very minor comments.
admin_permissions
to API and testsCe qu'il y a à faire pour chaque nouveau modèle que l'on veut protéger :
SpamMixin
et overrideattributes_to_check_for_spam
pour mettre les champs que l'on veut checker automatiquement,embeds_to_check_for_spam
si on a des sous-ressources à check,spam_report_title
etspam_report_link
pour les notifs.SpamAPI
(de la même manière que les follow) pour pouvoir mettre en non spam@spam_protected()
sur les méthodes que l'on ne veut pas exécuter en cas de spam (elles seront automatiquement rejouées lors du passage au non spam)