New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix harvest big catalog #2980
Fix harvest big catalog #2980
Conversation
25ece18
to
461b95f
Compare
461b95f
to
0c6725d
Compare
This PR doesn't change anything about the bump to Python 3.10 but as soon as we are on Python 3.10 in CI we can mock S3 to have unit test on this feature. |
Indeed you are right. A question in the PR you use boto3 to interface with S3. We are maintaining a lib called Flask-storage that is already used by |
Yes we may use |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 thanks
udata user can use this feature or not, which is cool. If not, they will have a problem with huge catalogs but for me telling them that they need to use S3 for that is acceptable.
Linked to #2859 |
Fix datagouv/data.gouv.fr#1046
Require Python 3.9 for tests:
moto
to mock S3 in testsmoto
require a recentcryptography
cryptography
we need to updateauthlib
(see [WIP] Bump cryptography #2981)authlib
we need to updateflask-security
(not sure but the CI on the PR above seems to show errors inflask-security
we the new version ofauthlib
flask-security
we need to update Python