Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move import User to runtime #3013

Merged
merged 4 commits into from Apr 15, 2024
Merged

Move import User to runtime #3013

merged 4 commits into from Apr 15, 2024

Conversation

ThibaudDauce
Copy link
Contributor

No description provided.

Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have some context on this change for future reference? :)

I wonder if it would lead to some performance downgrades for importing the User models at runtime for each request?

@ThibaudDauce
Copy link
Contributor Author

Do you have some context on this change for future reference? :)

I wonder if it would lead to some performance downgrades for importing the User models at runtime for each request?

In the dataservice PR I have some problems while importing the API force the import of User (you need the api module to create fields with api.model() and having User imported put a unwanted constraint. import are cache by Python, the performance downgrades should be negligeable I think.

MurdoqZodoq

This comment was marked as off-topic.

Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ThibaudDauce ThibaudDauce merged commit 0d74ddb into master Apr 15, 2024
1 check passed
@ThibaudDauce ThibaudDauce deleted the move_to_runtime_import branch April 15, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants