-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplifying installation, documentation and npm update #374
Conversation
[![JavaScript Dependencies Status](https://david-dm.org/etalab/udata.svg)](https://david-dm.org/etalab/udata) | ||
[![Join the chat at https://gitter.im/etalab/udata](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/etalab/udata?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) | ||
|
||
uData is an open and social data hub. This currently a work in progress and API is subject to change until the first official release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should update that? @noirbizarre ? (btw, missing is
I think)
That PR made my day! |
Glad it made your day, it made my week! 😜 |
|
||
git clone https://github.com/etalab/udata.git | ||
|
||
Install your [virtualenv](https://virtualenv.readthedocs.org/en/latest/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that really required if all we do is launching the docker-compose command? (Really curious because I don't use Docker)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker-compose will take care of elasticsearch, redis and mongodb. It does not bundle the python project itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on if we use docker-compose for the stack services only (Mongo, Elasticsearch, Redis...) or the development environment too. Right now, we are using docker-compose only for services, not the complete environment. (sorry, my page was not refreshed. I haven't seen your comment @vinyll )
The test broke because of readme.rst -> readme.md which was parsed for setup.py long-description. |
@@ -70,7 +62,7 @@ def dependency_links(filename): | |||
name='udata', | |||
version=__import__('udata').__version__, | |||
description=__import__('udata').__description__, | |||
long_description=long_description, | |||
long_description=clean_doc('README.md'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main problem is that long_description expected some restructuredtext :/
Step 1 of simplifying the installation:
inv assets
andinv watch
tonpm run assets:build
andnpm run assets:watch
) while preserving inv aliases.div
in udata/templates/header.html