Mark active users as confirmed #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A bit meta but I think that every migration should have an entry in the changelog to explain what the problem was and how we fixed it, thoughts? |
|
Changelog added |
jphnoel
reviewed
Dec 13, 2016
| * this migration confirm all active users. | ||
| */ | ||
|
|
||
| var result = db.user.update( |
There was a problem hiding this comment.
If MongoEngine supports ES6, why not use let instead of var ?
There was a problem hiding this comment.
sadly it doesn't support let this is not a full ES6 support yet
jphnoel
approved these changes
Dec 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a migration marking already active users but without the
confirmed_atattribute as confirmed