Fix common packaging #765
Merged
Fix common packaging #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbgk
approved these changes
Feb 16, 2017
| @@ -12,7 +12,10 @@ export const lang = config.lang; | |||
| const resources = {}; | |||
|
|
|||
| resources[lang] = {}; | |||
| resources[lang][NAMESPACE] = require('locales/' + NAMESPACE + '.' + lang + '.json'); | |||
| // Force split and async loading of locale (and so remove them from common.js) | |||
| } | ||
| })); | ||
| config.plugins.push( | ||
| new webpack.DefinePlugin({ |
There was a problem hiding this comment.
Why is that plugin required now?
There was a problem hiding this comment.
Setting this environment variable drop some Vue.js code (warnings and some debug helpers) in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR start to fix common.js packaging and side-effects and ensure:
mangle.keep_fnames = true)To reduce the size of the common chunk, we will have to: