New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle theme assets cache burst (fix #761) #781

Merged
merged 4 commits into from Feb 20, 2017

Conversation

Projects
None yet
2 participants
@noirbizarre
Member

noirbizarre commented Feb 19, 2017

This PR ensure theme assets have a proper cache burst which can be optionnaly extracted from the package version.

@noirbizarre noirbizarre added this to the 1.0.2 milestone Feb 19, 2017

Show outdated Hide outdated udata/theme.py Outdated
def theme_static_with_version(ctx, filename, external=False):
'''Override the default theme static to add cache burst'''
url = global_theme_static(ctx, filename, external=external)
if url.endswith('/'): # this is a directory, no need for cache burst

This comment has been minimized.

@davidbgk

davidbgk Feb 19, 2017

Member

Does it happen?

@davidbgk

davidbgk Feb 19, 2017

Member

Does it happen?

This comment has been minimized.

@noirbizarre

noirbizarre Feb 20, 2017

Member

@noirbizarre noirbizarre merged commit b61d593 into opendatateam:master Feb 20, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:gh-761-theme-assets-cache-burst branch Feb 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment