Raise maximum tag size to 96 #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbgk
suggested changes
Feb 20, 2017
udata/utils.py
Outdated
| @@ -199,9 +200,10 @@ def recursive_get(obj, key): | |||
| return recursive_get(value, parts) if parts else value | |||
|
|
|||
|
|
|||
| def unique_string(length=None): | |||
| def unique_string(length=36): | |||
There was a problem hiding this comment.
Let's name that magic number UUID_LENGTH?
udata/utils.py
Outdated
| '''Generate unique string''' | ||
| string = str(uuid4()) | ||
| # We need a string longer than length and an UUID is 36 chars length | ||
| string = str(uuid4()) * int(math.ceil(length / 36.0)) | ||
| return string[:length] if length else string |
There was a problem hiding this comment.
string is the name of a standard module.
There was a problem hiding this comment.
Which is not imported and as it's not a builtin, there is no collision.
I changed for uuid but it's also a standard module and the result is not an uuid but just a string,
so I propose to keep string as it's explicit
udata/utils.py
Outdated
| '''Generate unique string''' | ||
| string = str(uuid4()) | ||
| # We need a string longer than length and an UUID is 36 chars length | ||
| string = str(uuid4()) * int(math.ceil(length / 36.0)) |
There was a problem hiding this comment.
Given our use-case, I would just add * 2. Less clever but more readable :)
There was a problem hiding this comment.
* 2 is not sufficient, we need at least 3.
But I spent too much time searching the cause of the test failure so lets make it work with any length.
davidbgk
approved these changes
Feb 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise maximum tag length to at least support official INSPIRE tags