Optimized imgs for territories placeholders, fix #788 #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noirbizarre
approved these changes
Feb 21, 2017
| <li class="search-result territory-result"> | ||
| <a href="{{ territory.url }}" title="{{ territory.name }}"> | ||
| <div class="result-logo pull-left"> | ||
| <img alt="{{ territory.name }}" | ||
| src="{{ logo }}" | ||
| width="70" height="70"> | ||
| width="64" height="70"> |
There was a problem hiding this comment.
Is the ratio working with all fetched logos ?
There was a problem hiding this comment.
All logos have different sizes and the general case is the placeholder which matches blazons so I think it's a good trade off.
|
(Add a changelog entry before merge) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gouvfr counterpart: etalab/udata-gouvfr#158