New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop jquery.dotdotdot for a lighter css-only solution #853
Conversation
I'm confused with provided screenshots 🤔 |
Alright thanks, the example confused me because it looks spam-y :) Anyway, I don't get why sometimes you use |
On some element, the |
CHANGELOG.md
Outdated
@@ -22,6 +22,9 @@ | |||
- bleach and html5lib have been updated leading to more secure html/markdown cleanup | |||
and (better performances)[http://bluesock.org/~willkg/blog/dev/bleach_2_0.html] | |||
[#838](https://github.com/opendatateam/udata/pull/838) | |||
- drop jquery.dotdotdot for a lighter css-only solution (less memomry consumption) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: memory
@@ -8,8 +8,8 @@ | |||
width="70" height="70"> | |||
</div> | |||
{{ badge_if_certified(organization) }} | |||
<div class="result-body ellipsis-dot"> | |||
<h4 class="result-title">{{ organization.name }}</h4> | |||
<div class="result-body ellipsis"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not ellipsis
on h4
below and clamp-2
on the following div
following the same pattern as others?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mistake on this one, it should be on the h4
This PR drop
jquery-dotdotdot
for a lighter css-only solution that should improve memory consumptionLine clamping, webkit version:
Firefox/IE version (only difference, no
...
ellipsis :