Fix topic search #892
Merged
Fix topic search #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbgk
reviewed
May 3, 2017
| self.assertEqual(len(result), 0) | ||
|
|
||
| def test_empty_search_with_match(self): | ||
| '''Should only return no data with at least one tag''' |
There was a problem hiding this comment.
Should only return data matching topic's tag? Otherwise I don't get the logic?
| excluded = VisibleDatasetFactory.create_batch(2, tags=[ | ||
| 'out', 'filtered' | ||
| ]) | ||
| topic = TopicFactory(tags=['in', 'no-match']) |
There was a problem hiding this comment.
Is the no-match required if not tested?
| with self.autoindex(): | ||
| included = VisibleDatasetFactory.create_batch(2, tags=['in']) | ||
| excluded = VisibleDatasetFactory.create_batch(2, tags=['out']) | ||
| topic = TopicFactory(tags=['in', 'no-match']) |
There was a problem hiding this comment.
Yes, ensures at least is the condition, not all
davidbgk
approved these changes
May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures dataset or reuse without the required tags are never included in topic search