"Path" in branch name is not recognised

[loziju]

devshop version: 0.5.4

In github, I created branch with "path" in the name, e.g. features/new-theme. Please refer to the screenshot below. Please also note that there is another branch named new-theme which will be explained below.

In devshop, branch with "path" only shows the last component of the path, e.g. features/new-theme is shown as new-theme, features/foo/bar is shown as bar. When creating a new environment and selecting bar, master branch is the one being deployed to the new environment.

The screenshot above was done after another branch: new-theme was created. This is to circumvent the issue of devshop not detecting features/new-theme.

[jonpugh]

Hi @loziju, thanks for reporting this.

The problem is in the function getBranchesAndTags(): https://github.com/opendevshop/devmaster/blob/0.x/modules/devshop/devshop_projects/drush/contexts.inc#L65

I am not great at regex and processing so it's just a bunch of "explode()" calls.

We should probably look into using GitWrapper for this, it's likely they figured out how to get a list of branches and tags in a much more reliable way.

[jonpugh]

Thanks @loziju, this was fixed in commit opendevshop/devmaster@389019a