Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRO - rework overall report creation (and single store) logic #310

Closed
clemensutschig opened this issue May 4, 2020 · 1 comment · Fixed by #318
Closed

MRO - rework overall report creation (and single store) logic #310

clemensutschig opened this issue May 4, 2020 · 1 comment · Fixed by #318
Assignees
Labels
enhancement New feature or request

Comments

@clemensutschig
Copy link
Member

clemensutschig commented May 4, 2020

Today single repo docs (tir/dtr) are put into the json tree that represent the project.. this has two major drawbacks:

  1. We cannot dump the tree into the overall docs where it would belong, as the bytes are still there and
  2. we reinvent jenkins std functionality.. namely 'stash

So rather than putting byte[] into the Project json structure we should put in the names of the docs we stash and use that to generate the overall reports..

References:

  1. Byte[] into Structure: https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/src/org/ods/orchestration/usecase/LeVADocumentUseCase.groovy#L1143

  2. Overall.. byte [] out of Structure: https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/src/org/ods/orchestration/usecase/DocGenUseCase.groovy#L83

  3. Finalize.. toString() contains the byte[] : https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/src/org/ods/orchestration/FinalizeStage.groovy#L65

If we remove the document byte[] before the overall doc creation.. it will fail

@clemensutschig clemensutschig added the enhancement New feature or request label May 4, 2020
@clemensutschig clemensutschig changed the title MRO - rework overall Report logic MRO - rework overall report creation (and single store)logic May 4, 2020
@clemensutschig clemensutschig changed the title MRO - rework overall report creation (and single store)logic MRO - rework overall report creation (and single store) logic May 4, 2020
@clemensutschig
Copy link
Member Author

clemensutschig commented May 4, 2020

In Case One wants to Test it.. move https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/src/org/ods/orchestration/FinalizeStage.groovy#L66 ahead of line 63.. then the gazillion bytes will show up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
1 participant