Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM: deploy phase verifies target project and login, even if there are only non-installable components #810

Closed
clemensutschig opened this issue Dec 17, 2021 · 0 comments · Fixed by #814
Assignees
Labels
enhancement New feature or request

Comments

@clemensutschig
Copy link
Member

clemensutschig commented Dec 17, 2021

Is your feature request related to a problem? Please describe.
RM offers two component types, those that are installed on ocp (e.g. ods, ods-service,...) and those that are not (e.g. ods-infra, ods-test)

If there are only non-installed components, its pointless to look for external cluster login, or check if the target project is available in the deploy stage. (causes just yet another empty namespace)

https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/src/org/ods/orchestration/DeployStage.groovy#L90-L113

Describe the solution you'd like
Only do those checks if there are "ods-installable" components in the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant