Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM: test component causes new jenkins (run) instance after branch is created for release #823

Closed
clemensutschig opened this issue Jan 4, 2022 · 0 comments · Fixed by #814
Assignees
Labels
bug Something isn't working

Comments

@clemensutschig
Copy link
Member

clemensutschig commented Jan 4, 2022

Describe the bug
While ods type components - create a commit with the exported state in the finalizeStage / FinalizeOdsComponent - and mark with with CI SKIP - this is not done for other component types. This causes a nasty downstream effect ... namely - that a new instance is kicked off (based on the creation of the release branch - that can do all sorts of bad things, in the best case it only fails)

To Reproduce
Steps to reproduce the behavior:

  1. add a test component to your project
  2. assemble a bundle for dev
  3. see a NEW instance created (that is running) for the test component (release/....) - which is NOT stopping with "CI skip"

Expected behavior

  1. a new instance is created with a CI skip commit in there, to omit the running

Affected version (please complete the following information):

  • OpenShift: [3.11]
  • OpenDevStack [master, 4.x, 3.x]

Context
https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/src/org/ods/orchestration/util/MROPipelineUtil.groovy#L346-L348 - which leads to an export CI skip commit

@clemensutschig clemensutschig added the bug Something isn't working label Jan 4, 2022
@clemensutschig clemensutschig self-assigned this Jan 10, 2022
@clemensutschig clemensutschig added this to To Do in OpenDevStack 4.1.0 via automation Jan 10, 2022
OpenDevStack 4.1.0 automation moved this from To Do to Done Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant