Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aqua scanner stage does not have timeout #899

Closed
braisvq1996 opened this issue Apr 27, 2022 · 5 comments · Fixed by #905
Closed

Aqua scanner stage does not have timeout #899

braisvq1996 opened this issue Apr 27, 2022 · 5 comments · Fixed by #905
Labels
bug Something isn't working

Comments

@braisvq1996
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Aqua does nto have any timeout in either the stage or the aquasec scan execution.

Describe the solution you'd like
A default timeout should be placed to avoid the pipeline to run infinitelly in the case of unexpected errors and enable the posibility of increasing it in the aqua stage options

Describe alternatives you've considered
A timeout either in the stage or in the aquasec scan command.

Additional context
The flag to add a timeout in the aquasec scan command is -T
image

@metmajer
Copy link
Member

@braisvq1996 @hrcornejo ...and in case of a timeout send out an error email as we do for other Aqua integration related errors. Brais, we need to fix the email service in Jenkins, otherwise we do not see these issues. @jorge-romero @jafarre-viewnext this seems rather simple and could be treated as a Bug in the next white week vs. a full Shape.

@metmajer
Copy link
Member

@braisvq1996 what about we add this to a Maintenance project?

@metmajer metmajer added the bug Something isn't working label Apr 27, 2022
@braisvq1996 braisvq1996 added this to To Do in ODS Maintenance Apr 29, 2022
@metmajer
Copy link
Member

@braisvq1996 @renedupont it sounds like the response time depends on the number of requests the Aqua server needs to handle. What do you suggest as a feasible timeout?

@metmajer
Copy link
Member

FYI @hrcornejo

@braisvq1996
Copy link
Contributor Author

braisvq1996 commented May 11, 2022

@braisvq1996 @renedupont it sounds like the response time depends on the number of requests the Aqua server needs to handle. What do you suggest as a feasible timeout?

To avoid future issues we can set a default timeout (~5 min) an allow to change it in pipeline stage options as we have for the Openshift build and deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants