Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ods-deploy-helm support age for secret management #293

Closed
gerardcl opened this issue Nov 22, 2021 · 2 comments · Fixed by #301
Closed

ods-deploy-helm support age for secret management #293

gerardcl opened this issue Nov 22, 2021 · 2 comments · Fixed by #301
Assignees
Milestone

Comments

@gerardcl
Copy link
Member

From conversations here: #282

We would like to have a better solution to handle sencrets within helm usage in the ods-pipeline, basically required within ods-deploy-helm and documentation for the initial/updating project and component secrets.

We have seen that age is being recommended to be used by sops and helm-secrets is adding support to it.

The proposal is then to add support for age (make it default) and replace the current default pgp approach.

FYI @renedupont @michaelsauter @kuebler

@gerardcl gerardcl self-assigned this Nov 22, 2021
@gerardcl gerardcl modified the milestone: 0.3.0 Nov 22, 2021
@gerardcl
Copy link
Member Author

@michaelsauter this does not look like a breaking change, right? do we add it to master right away? or?

@michaelsauter
Copy link
Member

@gerardcl Depends how you do it. If we replace PGP, then this is a breaking change. That said, we are pre-1.0, which means any breaking change can be introduced in a minor version. Whatever is in master is going to be released as 0.2.0, so you can introduce the change in master. Personally I am OK with going all-in with age - otherwise we need to test+support two ways of doing the same thing. Until we encounter a use case that needs PGP I would try to live without it.

@michaelsauter michaelsauter added this to the 0.2.0 milestone Nov 23, 2021
@gerardcl gerardcl mentioned this issue Nov 23, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants