Use Go 1.19 for building #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsauter
force-pushed
the
feature/go1-19-builder
branch
from
582817b
to
4354049
Compare
Triggered by experimenting with log/slog, which requires atomic.Int64. I would have used Go 1.20 but it is not available via homebrew yet.
michaelsauter
force-pushed
the
feature/go1-19-builder
branch
from
4354049
to
80c24d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by experimenting with
log/slog, which requiresatomic.Int64, which was added in Go 1.19. I would have used Go 1.20 but it is not available via homebrew yet.This will be handy in #656. I wanted to extract it into its own PR to isolate potential issues arising from the changed builder image.
Tasks:
docs/designdirectory or not applicabledocsdirectory or not applicablemake test) or not applicable