Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation with --enable-gst fails #13

Closed
nickpiggott opened this issue Jun 3, 2020 · 3 comments
Closed

Compilation with --enable-gst fails #13

nickpiggott opened this issue Jun 3, 2020 · 3 comments

Comments

@nickpiggott
Copy link

Environment

  • Debian Jessie
  • All specified gstream1.0 libraries and plugins installed using apt
  • ./configure --enable-vlc --enable-gst

Problem
Compilation fails with the error:

src/GSTInput.cpp: In member function ‘virtual void GSTInput::prepare()’: src/GSTInput.cpp:124:33: error: ‘GST_AUDIO_RESAMPLER_FILTER_MODE_FULL’ was not declared in this scope "sinc-filter-mode", GST_AUDIO_RESAMPLER_FILTER_MODE_FULL,

I couldn't find any files in the GStreamer libraries (/usr/include/gstreamer-1.0/gst) that defined that static value, although the GStreamer audioresample documentation suggests it should be defined.

Workaround
I commented out the explicit definition of sinc-filter-mode, which the documentation suggests defaults to " GST_AUDIO_RESAMPLER_FILTER_MODE_AUTO". Compilation then succeeded, and the GStreamer input to odr-audioenc worked apparently correctly.

@mpbraendli
Copy link
Member

The GST version jessie includes is too old If you're able to do a simple patch that sets the filter mode if the GST version allows it I might take it, but I don't want to take too much time for jessie support.

@nickpiggott
Copy link
Author

If I can find the time, I'll wrap that call in a
#IFDEF
and adjust it accordingly.

@mpbraendli
Copy link
Member

I hope c9b1492 fixes that, I didn't try on jessie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants