Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish(lxl): polish mujoco(hopper,walker2d) config #259

Merged
merged 11 commits into from
Apr 15, 2022

Conversation

lixl-st
Copy link
Contributor

@lixl-st lixl-st commented Apr 2, 2022

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@puyuan1996 puyuan1996 added the config Update config label Apr 2, 2022
@puyuan1996
Copy link
Collaborator

puyuan1996 commented Apr 3, 2022

please modify PR's name according to our guideline,something like this:
polish(lxl): polish mujoco(hopper,walker2d) config
and please solve the conflicts.

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #259 (ed390c2) into main (3734c06) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   85.96%   85.93%   -0.04%     
==========================================
  Files         481      481              
  Lines       36789    36789              
==========================================
- Hits        31625    31613      -12     
- Misses       5164     5176      +12     
Flag Coverage Δ
unittests 85.93% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/framework/message_queue/tests/test_redis.py 84.84% <0.00%> (-15.16%) ⬇️
ding/framework/message_queue/redis.py 80.95% <0.00%> (-4.77%) ⬇️
ding/envs/env_manager/subprocess_env_manager.py 81.01% <0.00%> (-0.85%) ⬇️
ding/worker/learner/base_learner.py 95.37% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3734c06...ed390c2. Read the comment docs.

@froyohunter
Copy link

I propose for m1 (arm64) to be added to do_platform_test
so many failed wheels with default set-ups......

@puyuan1996 puyuan1996 changed the title Polish config lixuelin polish(lxl): polish mujoco(hopper,walker2d) config Apr 6, 2022
dizoo/mujoco/config/hopper_trex_onppo_config.py Outdated Show resolved Hide resolved
dizoo/mujoco/config/hopper_trex_sac_config.py Outdated Show resolved Hide resolved
dizoo/mujoco/config/walker2d_trex_onppo_config.py Outdated Show resolved Hide resolved
dizoo/mujoco/config/walker2d_trex_sac_config.py Outdated Show resolved Hide resolved
@PaParaZz1 PaParaZz1 merged commit e438cc9 into opendilab:main Apr 15, 2022
puyuan1996 pushed a commit to puyuan1996/DI-engine that referenced this pull request Apr 18, 2022
* polish(lxl): format configs of hopper and walker2d

* polish(lxl): format configs of hopper and walker2d

* polish(lxl): add starting cmd for trex

* polish(lxl): delete env.manager.shared_memory=False

* polish(lxl): polish gail, trex cfg in hopper and walker2d

* polish(lxl): remove duplicated ppo cfg

* polish(lxl): polish style and default settings
@lixl-st lixl-st deleted the polish-config-lixuelin branch June 6, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Update config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants