Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zzh): IBC minor fix. #477

Merged
merged 1 commit into from
Sep 9, 2022
Merged

fix(zzh): IBC minor fix. #477

merged 1 commit into from
Sep 9, 2022

Conversation

ZHZisZZ
Copy link
Collaborator

@ZHZisZZ ZHZisZZ commented Sep 9, 2022

Remove redundant leaf nodes (action samples) from computation graph;

Correct function name from _langevin_action_gives_obs to _langevin_action_given_obs.

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

Remove redundant leaf nodes (action samples) from computation graph;

Correct function name from `_langevin_action_gives_obs` to `_langevin_action_given_obs`.
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #477 (64aeb17) into main (d289dee) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   85.73%   85.66%   -0.07%     
==========================================
  Files         537      537              
  Lines       42992    42994       +2     
==========================================
- Hits        36859    36832      -27     
- Misses       6133     6162      +29     
Flag Coverage Δ
unittests 85.66% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/model/template/ebm.py 94.44% <100.00%> (+0.05%) ⬆️
ding/model/template/tests/test_ebm.py 100.00% <100.00%> (ø)
ding/framework/message_queue/tests/test_nng.py 73.07% <0.00%> (-26.93%) ⬇️
ding/worker/learner/comm/flask_fs_learner.py 83.12% <0.00%> (-8.13%) ⬇️
ding/utils/data/dataloader.py 44.55% <0.00%> (-2.60%) ⬇️
ding/utils/tests/test_k8s_launcher.py 88.67% <0.00%> (-1.89%) ⬇️
ding/worker/collector/marine_parallel_collector.py 89.86% <0.00%> (-1.39%) ⬇️
ding/worker/learner/tests/test_base_learner.py 91.01% <0.00%> (-1.13%) ⬇️
ding/framework/tests/test_parallel.py 96.26% <0.00%> (-0.94%) ⬇️
ding/envs/env_manager/subprocess_env_manager.py 76.96% <0.00%> (+0.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 merged commit ac9f33c into opendilab:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants