feature(zc): add carracing in box2d #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #575 +/- ##
==========================================
+ Coverage 83.60% 83.67% +0.06%
==========================================
Files 562 564 +2
Lines 46020 46110 +90
==========================================
+ Hits 38477 38581 +104
+ Misses 7543 7529 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Super1ce
changed the title
puyuan1996
reviewed
Feb 7, 2023
PaParaZz1
changed the title
PaParaZz1
requested changes
Feb 8, 2023
|
add the information of this env in env table |
PaParaZz1
requested changes
Feb 8, 2023
|
|
||
| nstep = 3 | ||
| carracing_dqn_config = dict( | ||
| exp_name='carracing_dqn_seed0-withouconfig', |
PaParaZz1
requested changes
Feb 8, 2023
| self._replay_path_gif = cfg.replay_path_gif | ||
| self._save_replay_gif = cfg.save_replay_gif | ||
| self._save_replay_count = 0 | ||
| if 'Continuous' in self._env_id: |
There was a problem hiding this comment.
remove Continuous related codes, which is abandoned in latest gym
| self._env = ObsPlusPrevActRewWrapper(self._env) | ||
| # self._observation_space = self._env.observation_space | ||
| self._observation_space = gym.spaces.Box( | ||
| low=np.min(self._env.observation_space.low), |
There was a problem hiding this comment.
correct range (after dividing 255)
| episode_trigger=lambda episode_id: True, | ||
| name_prefix='rl-video-{}'.format(id(self)) | ||
| ) | ||
| if hasattr(self._cfg, 'obs_plus_prev_action_reward') and self._cfg.obs_plus_prev_action_reward: |
There was a problem hiding this comment.
remove this wrapper, it is only used in some special cases.
PaParaZz1
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add CarRacing env and config of DQN
result:
Related Issue
TODO