Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish(pu): polish comments in a2c/bcq/fqf/ibc policy #768

Merged
merged 8 commits into from
Jan 25, 2024

Conversation

puyuan1996
Copy link
Collaborator

@puyuan1996 puyuan1996 commented Jan 22, 2024

Description

  • polish(pu): polish comments in dqn, a2c, bcq, fqf, ibc.

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@puyuan1996 puyuan1996 added doc Documentation config Update config labels Jan 22, 2024
ding/policy/a2c.py Outdated Show resolved Hide resolved
ding/policy/a2c.py Outdated Show resolved Hide resolved
ding/policy/bcq.py Outdated Show resolved Hide resolved
ding/policy/bcq.py Outdated Show resolved Hide resolved
ding/policy/dqn.py Outdated Show resolved Hide resolved
ding/policy/ibc.py Outdated Show resolved Hide resolved
ding/policy/bcq.py Show resolved Hide resolved
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a57bc30) 76.78% compared to head (1e07862) 76.79%.

Files Patch % Lines
ding/policy/bcq.py 66.66% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #768   +/-   ##
=======================================
  Coverage   76.78%   76.79%           
=======================================
  Files         676      676           
  Lines       54431    54427    -4     
=======================================
- Hits        41797    41796    -1     
+ Misses      12634    12631    -3     
Flag Coverage Δ
unittests 76.79% <87.87%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaParaZz1 PaParaZz1 merged commit 74c6a1e into opendilab:main Jan 25, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Update config doc Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants