Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[BUG] Wrap Text on Monitor Name #237

Open
abdalians opened this issue Jan 22, 2021 · 3 comments
Open

[BUG] Wrap Text on Monitor Name #237

abdalians opened this issue Jan 22, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@abdalians
Copy link

Describe the bug
Under Alerting > Monitors The Monitor name should wrap the text for Monitor Name. At the moment it shows ... after 22 characters.

Other plugins installed
security

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Alerting > Monitors'
  2. Create a Monitor with name larger than 22 characters.

Expected behavior
It should either wrap text or make the column width adjustable

Screenshots
If applicable, add screenshots to help explain your problem.
image

Desktop (please complete the following information):

  • OS: IOS 11.1
  • Browser Chrome
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@ftianli-amzn ftianli-amzn transferred this issue from opendistro-for-elasticsearch/alerting Jan 25, 2021
@ftianli-amzn ftianli-amzn added the enhancement New feature or request label Jan 25, 2021
@tlfeng
Copy link
Contributor

tlfeng commented Feb 6, 2021

Hi abdalians,

Thank you for pointing it out!
I transferred the issue from Alerting plugin repo to here, as it's related to the front-end part.
Besides, I labeled the issue as a feature instead of a bug.

I think wrapping the text to the column width, can be made by setting the truncateText property to false in this line:

And there are other properties like width which can set the width of the column.
IMO, wrapping the text sounds a good idea.

@abdalians
Copy link
Author

setting the truncateText: false did not change the behaviour. also if there was a tool tip that showed the full name that could help too..

@abdalians
Copy link
Author

abdalians commented Mar 8, 2021

poking around the directories I found this file

/usr/share/kibana/plugins/opendistro-alerting/public/pages/Monitors/containers/Monitors/snapshots/Monitors.test.js.snap

I edited line 43 in the above file in addition to line 33 in tableUtils.js and cleared the optimize directory and restarted kibana to achieve the desired result. i.e. Monitor names are text wrapping properly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants