Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Show error message for the failed monitor runs in dashboard #182

Merged
merged 1 commit into from Oct 1, 2020
Merged

Conversation

ftianli-amzn
Copy link

@ftianli-amzn ftianli-amzn commented Sep 11, 2020

Issue #, if available:

Description of changes:

Currently if there is an error occurs in monitor runs, it just shown as Error, the error message is missing. This PR will make it shown as Error: <error message>.

  • In Dashboard
    image

  • In Monitor Detail page
    image

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ftianli-amzn
Copy link
Author

yarn test:jest

Test Suites: 6 skipped, 78 passed, 78 of 84 total
Tests:       20 skipped, 366 passed, 386 total
Snapshots:   127 passed, 127 total
Time:        35.461s
Ran all test suites.
✨  Done in 36.74s.

@dbbaughe
Copy link
Contributor

What is the longest length error that will be shown? How will that look on the UI without being truncated in a narrow column?

@ftianli-amzn
Copy link
Author

Test Suites: 6 skipped, 78 passed, 78 of 84 total
Tests:       20 skipped, 366 passed, 386 total
Snapshots:   127 passed, 127 total
Time:        42.712s
Ran all test suites.
✨  Done in 43.88s.

@ftianli-amzn
Copy link
Author

What is the longest length error that will be shown? How will that look on the UI without being truncated in a narrow column?

Hi, finally we decided not to truncate the text in the table. The error messages will be refined and optimized in the backend to be more user friendly, while the original long messages are reserved as well.

@ftianli-amzn ftianli-amzn added the enhancement New feature or request label Sep 29, 2020
@ftianli-amzn ftianli-amzn merged commit e7f4ba3 into opendistro-for-elasticsearch:master Oct 1, 2020
@ftianli-amzn ftianli-amzn deleted the err_msg_alert_run branch November 17, 2020 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants