This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add AllowList for Destinations #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'Edit' on disallowed Destinations
dbbaughe
reviewed
Oct 3, 2020
dbbaughe
reviewed
Oct 3, 2020
dbbaughe
reviewed
Oct 3, 2020
dbbaughe
reviewed
Oct 3, 2020
public/pages/Destinations/containers/CreateDestination/utils/validations.js
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Oct 3, 2020
public/pages/Destinations/containers/CreateDestination/ManageSenders/ManageSenders.js
Show resolved
Hide resolved
dbbaughe
approved these changes
Oct 5, 2020
lezzago
approved these changes
Oct 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds AllowList support for Destinations on Kibana.
This PR is for the Kibana changes related to the backend changes to add a Destination AllowList
Note: Tests for
DestinationsListandDashboardwere failing prior to this PR. They seemed to all be snapshot failures, after reviewing the Kibana behavior, I updated the snapshots since everything seemed good but it might still be worth looking at the previous GitHub Action run to see if changes prior to this one behave as expected.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.