This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Remove 'JSON.stringify()' from constructing the body of API calls in request handlers #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftianli-amzn
changed the title
ftianli-amzn
changed the title
lezzago
approved these changes
Dec 8, 2020
bowenlan-amzn
approved these changes
Dec 9, 2020
ftianli-amzn
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
In the new Kibana platform, the
bodyof the HTTP requests have to be wrapped in{ body: JSON.stringify(...) }before entering the request handlers, which was previously done in the handlers.The PR does the code cleanup after the migration to new Kibana platform(PR #209).
body: JSON.stringify(req.body)->body: req.bodyHave manually tested the related actions can be performed correctly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.