Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add action to DELETE /_alerting/destinations/{id} #233

Merged

Conversation

skkosuri-amzn
Copy link
Contributor

Issue #, if available:
#232

Description of changes:
Refer: #232

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #233 into master will increase coverage by 0.10%.
The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #233      +/-   ##
============================================
+ Coverage     76.14%   76.24%   +0.10%     
- Complexity      157      162       +5     
============================================
  Files            63       66       +3     
  Lines          2586     2635      +49     
  Branches        402      420      +18     
============================================
+ Hits           1969     2009      +40     
+ Misses          421      412       -9     
- Partials        196      214      +18     
Impacted Files Coverage Δ Complexity Δ
...csearch/alerting/action/DeleteDestinationAction.kt 66.66% <66.66%> (ø) 0.00 <0.00> (?)
...ting/transport/TransportDeleteDestinationAction.kt 66.66% <66.66%> (ø) 0.00 <0.00> (?)
...ndistroforelasticsearch/alerting/AlertingPlugin.kt 88.70% <100.00%> (+0.37%) 0.00 <0.00> (ø)
...search/alerting/action/DeleteDestinationRequest.kt 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...lerting/resthandler/RestDeleteDestinationAction.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...roforelasticsearch/alerting/model/action/Action.kt 70.17% <0.00%> (-10.96%) 0.00% <0.00%> (ø%)
...stroforelasticsearch/alerting/alerts/AlertError.kt 80.00% <0.00%> (-6.67%) 0.00% <0.00%> (ø%)
...relasticsearch/alerting/model/destination/Chime.kt 57.14% <0.00%> (-2.86%) 0.00% <0.00%> (ø%)
...relasticsearch/alerting/model/destination/Slack.kt 57.14% <0.00%> (-2.86%) 0.00% <0.00%> (ø%)
...h/alerting/resthandler/RestExecuteMonitorAction.kt 73.17% <0.00%> (-2.44%) 0.00% <0.00%> (ø%)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af3ebbc...5ed9201. Read the comment docs.


var destinationID: String? = null
var refreshPolicy: WriteRequest.RefreshPolicy? = null
val destinationId: String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NP: I believe the old naming scheme was more appropriate since we typically only begin lowercasing acronyms when they exceed two letters.

This is not a blocker for this PR, we can always change it in another one of the API PRs.

@skkosuri-amzn skkosuri-amzn merged commit 2a3fb54 into opendistro-for-elasticsearch:master Aug 11, 2020
@bowenlan-amzn bowenlan-amzn added the enhancement New feature or request label Sep 8, 2020
tlfeng pushed a commit that referenced this pull request Feb 6, 2021
* Issue #232 : Add action to DELETE /_alerting/destinations/{id}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants