Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Inject roles for alerting background jobs #259

Merged
merged 10 commits into from
Oct 1, 2020
Merged

Conversation

skkosuri-amzn
Copy link
Contributor

Issue #, if available:
#215
Description of changes:
#215

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #259 into master will increase coverage by 0.00%.
The diff coverage is 70.05%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #259   +/-   ##
=========================================
  Coverage     80.37%   80.37%           
  Complexity      199      199           
=========================================
  Files           149      150    +1     
  Lines          4810     4897   +87     
  Branches        635      647   +12     
=========================================
+ Hits           3866     3936   +70     
- Misses          597      608   +11     
- Partials        347      353    +6     
Impacted Files Coverage Δ Complexity Δ
...rting/transport/TransportIndexDestinationAction.kt 51.68% <13.33%> (-0.04%) 0.00 <0.00> (ø)
...rting/transport/TransportAcknowledgeAlertAction.kt 89.09% <50.00%> (+0.20%) 0.00 <0.00> (ø)
.../alerting/transport/TransportIndexMonitorAction.kt 66.18% <55.55%> (+4.09%) 0.00 <0.00> (ø)
...endistroforelasticsearch/alerting/MonitorRunner.kt 76.68% <66.66%> (-0.39%) 0.00 <0.00> (ø)
...orelasticsearch/alerting/util/AlertingException.kt 67.85% <67.85%> (ø) 0.00 <0.00> (?)
...lerting/transport/TransportExecuteMonitorAction.kt 69.69% <71.42%> (-5.31%) 0.00 <0.00> (ø)
...ndistroforelasticsearch/alerting/AlertingPlugin.kt 90.62% <75.00%> (-0.87%) 0.00 <0.00> (ø)
...ting/transport/TransportDeleteDestinationAction.kt 70.00% <75.00%> (+3.33%) 0.00 <0.00> (ø)
...alerting/transport/TransportSearchMonitorAction.kt 62.50% <75.00%> (+5.35%) 0.00 <0.00> (ø)
...alerting/resthandler/RestAcknowledgeAlertAction.kt 84.00% <100.00%> (+4.83%) 0.00 <0.00> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01269ec...68d2098. Read the comment docs.

Comment on lines 449 to 453
/*
* Commented. This test is not relevant anymore. We can't create a monitor with illegal chars.
* This is replaced with MonitorRestApiIT.`test creating a monitor with illegal index name`
*/
/*fun `test execute monitor with bad search`() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why note remove the code since it has essentially became dead code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Adding comments here and deleting the dead code.

     * Commented. This test is not relevant anymore. We can't create a monitor with illegal chars.
     * This is replaced with MonitorRestApiIT.`test creating a monitor with illegal index name`

@@ -18,7 +18,7 @@
import org.elasticsearch.common.Strings;

/**
* This class is a place holder for destination response metadata
` * This class is a place holder for destination response metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this accidentally added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixed

lezzago
lezzago previously approved these changes Sep 30, 2020
@skkosuri-amzn skkosuri-amzn merged commit 9ab735c into master Oct 1, 2020
skkosuri-amzn added a commit that referenced this pull request Oct 1, 2020
* Inject roles for background jobs
* Removed dead test
tlfeng pushed a commit that referenced this pull request Feb 6, 2021
* Inject roles for background jobs
* Removed dead test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants