Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Use common-utils from maven, use withContext instead runBlocking #273

Merged

Conversation

skkosuri-amzn
Copy link
Contributor

Issue #, if available:

  1. Use common-utils from maven,
  2. use withContext instead runBlocking

Description of changes:
On #2
https://kotlin.github.io/kotlinx.coroutines/kotlinx-coroutines-core/kotlinx.coroutines/run-blocking.html
runBlocking: blocks the current thread interruptibly until its completion
withContext : Calls the specified suspending block with a given coroutine context, suspends until it completes, and returns the result.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #273 into master will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #273      +/-   ##
============================================
- Coverage     79.92%   79.83%   -0.10%     
+ Complexity      195      194       -1     
============================================
  Files           150      150              
  Lines          5132     5132              
  Branches        661      661              
============================================
- Hits           4102     4097       -5     
- Misses          666      668       +2     
- Partials        364      367       +3     
Impacted Files Coverage Δ Complexity Δ
...endistroforelasticsearch/alerting/MonitorRunner.kt 76.31% <100.00%> (ø) 0.00 <0.00> (ø)
...distroforelasticsearch/alerting/core/JobSweeper.kt 69.51% <0.00%> (-2.68%) 34.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d0e8ff...13e58e2. Read the comment docs.

@skkosuri-amzn skkosuri-amzn merged commit 043ba5c into opendistro-for-elasticsearch:master Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants