Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix parsing User info when User is null #279

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

lezzago
Copy link
Contributor

@lezzago lezzago commented Oct 23, 2020

Issue #, if available:

Description of changes:
Set User to null when parsing null User data from Monitor, Destination, or Alert object.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@skkosuri-amzn
Copy link
Contributor

thanks @lezzago

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #279 into master will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #279      +/-   ##
============================================
+ Coverage     79.28%   79.57%   +0.29%     
- Complexity      193      194       +1     
============================================
  Files           150      150              
  Lines          5132     5132              
  Branches        661      664       +3     
============================================
+ Hits           4069     4084      +15     
+ Misses          708      696      -12     
+ Partials        355      352       -3     
Impacted Files Coverage Δ Complexity Δ
...opendistroforelasticsearch/alerting/model/Alert.kt 87.50% <100.00%> (ø) 0.00 <0.00> (ø)
...endistroforelasticsearch/alerting/model/Monitor.kt 88.70% <100.00%> (ø) 0.00 <0.00> (ø)
...icsearch/alerting/model/destination/Destination.kt 75.00% <100.00%> (ø) 0.00 <0.00> (ø)
...distroforelasticsearch/alerting/util/IndexUtils.kt 71.42% <0.00%> (-2.39%) 0.00% <0.00%> (ø%)
...ticsearch/alerting/elasticapi/ElasticExtensions.kt 51.92% <0.00%> (+3.84%) 0.00% <0.00%> (ø%)
...ing/destination/client/DestinationEmailClient.java 77.50% <0.00%> (+5.00%) 8.00% <0.00%> (+1.00%)
...roforelasticsearch/alerting/alerts/AlertIndices.kt 75.59% <0.00%> (+9.44%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ecb4e...3403a98. Read the comment docs.

@lezzago lezzago merged commit 86aec1b into opendistro-for-elasticsearch:master Oct 23, 2020
tlfeng pushed a commit that referenced this pull request Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants