This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Allows encoding while constructing HTTP request for sending notification #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamshin
reviewed
Apr 18, 2019
...com/amazon/opendistroforelasticsearch/alerting/destination/client/DestinationHttpClient.java
Outdated
Show resolved
Hide resolved
vamshin
reviewed
Apr 18, 2019
...com/amazon/opendistroforelasticsearch/alerting/destination/client/DestinationHttpClient.java
Outdated
Show resolved
Hide resolved
vamshin
reviewed
Apr 18, 2019
...com/amazon/opendistroforelasticsearch/alerting/destination/client/DestinationHttpClient.java
Outdated
Show resolved
Hide resolved
vamshin
reviewed
Apr 18, 2019
...ava/com/amazon/opendistroforelasticsearch/alerting/destination/CustomWebhookMessageTest.java
Outdated
Show resolved
Hide resolved
vamshin
reviewed
Apr 18, 2019
...ava/com/amazon/opendistroforelasticsearch/alerting/destination/CustomWebhookMessageTest.java
Outdated
Show resolved
Hide resolved
vamshin
reviewed
Apr 18, 2019
|
@vamshin I just had to use charset while in entity as we've already set in headers on the POST so it wasn't required. I've removed other changes and added the charset for Body String. |
|
Can you please explain how to set up character encoding? And which version will fix this issue? |
Generally , you can setup like this
This will be released in next Opendistro version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#33
Description of changes:
We were not encoding the message while publishing, using the StringEntity constructor with the mime-type and charset.
application/jsonapplication/json, user can choose other values.Sample Chime notification :
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.