This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add settings to disable/enable AD dynamically #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jngz-es
approved these changes
May 4, 2020
ylwu-amzn
reviewed
May 4, 2020
| /** | ||
| * AD plugin enable/disable setting | ||
| */ | ||
| put(AD_PLUGIN_ENABLED, Setting.boolSetting(AD_PLUGIN_ENABLED, true, NodeScope, Dynamic)); |
There was a problem hiding this comment.
We will set AD plugin as enabled by default. After user disabling it and restart domain, are we able to read the latest configuration and set AD as disabled by defulat?
There was a problem hiding this comment.
It depends on whether they do it in a transient fashion or persistent fashion. If transient, after reboot, it would be enabled by default. If persistent, after reboot, it would disabled by default.
ylwu-amzn
approved these changes
May 4, 2020
This PR adds settings to disable/enable AD dynamically. AD plugin rejects RESTful requests and stops AD jobs when it is disabled. Testing done: - added tests to verify if AD plugin rejects RESTful requests when it is disabled - manually verified AD jobs are stopped when AD plugin is disabled
kaituo
added a commit
to kaituo/anomaly-detection
that referenced
this pull request
May 19, 2020
…search#105) This PR adds settings to disable/enable AD dynamically. AD plugin rejects RESTful requests and stops AD jobs when it is disabled. Testing done: - added tests to verify if AD plugin rejects RESTful requests when it is disabled - manually verified AD jobs are stopped when AD plugin is disabled
kaituo
added a commit
that referenced
this pull request
May 19, 2020
…" (#127) * Add settings to disable/enable AD dynamically (#105) This PR adds settings to disable/enable AD dynamically. AD plugin rejects RESTful requests and stops AD jobs when it is disabled. Testing done: - added tests to verify if AD plugin rejects RESTful requests when it is disabled - manually verified AD jobs are stopped when AD plugin is disabled * Add locale encoding as tests complains about UTF issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds settings to disable/enable AD dynamically. AD plugin rejects RESTful requests and stops AD jobs when it is disabled.
Testing done:
Usage:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.