This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Adding RestActions support for Detector Stats API #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding Unit Tests in the coming commit. |
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
============================================
+ Coverage 71.97% 72.08% +0.11%
- Complexity 1284 1294 +10
============================================
Files 143 146 +3
Lines 5980 6005 +25
Branches 469 469
============================================
+ Hits 4304 4329 +25
- Misses 1462 1463 +1
+ Partials 214 213 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kaituo
reviewed
Sep 24, 2020
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| public class SearchAnomalyDetectorAction extends ActionType<SearchResponse> { | |||
| public static final SearchAnomalyDetectorAction INSTANCE = new SearchAnomalyDetectorAction(); | |||
| public static final String NAME = "cluster:admin/opendistro/ad/detector/search"; | |||
| public static final String NAME = "cluster:admin/ad/search/detector"; | |||
There was a problem hiding this comment.
The old name sound more reasonable.
There was a problem hiding this comment.
Sure, that was some merge issue which showed up here.
Cleaned it up with another commit.
| @@ -249,6 +249,7 @@ List<String> jacocoExclusions = [ | |||
| 'com.amazon.opendistroforelasticsearch.ad.AnomalyDetectorRunner', | |||
| 'com.amazon.opendistroforelasticsearch.ad.indices.AnomalyDetectionIndices', | |||
| 'com.amazon.opendistroforelasticsearch.ad.util.ParseUtils', | |||
| 'com.amazon.opendistroforelasticsearch.ad.transport.StatsAnomalyDetectorTransportAction' | |||
There was a problem hiding this comment.
As we are already covering them in our IntegTests, its getting complicated to unit test it.
saratvemulapalli
changed the title
saratvemulapalli
changed the title
skkosuri-amzn
approved these changes
Sep 28, 2020
kaituo
approved these changes
Sep 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #195 *
Description of changes:
Adding RestActions support Detector Stats API which is needed for FGAC support.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.