This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Renaming all Actions to distinguish between internal and external facing #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
============================================
+ Coverage 70.03% 70.07% +0.04%
- Complexity 1815 1820 +5
============================================
Files 190 190
Lines 8867 8900 +33
Branches 756 757 +1
============================================
+ Hits 6210 6237 +27
- Misses 2301 2306 +5
- Partials 356 357 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saratvemulapalli
requested review from
ylwu-amzn,
kaituo,
ohltyler and
yizheliu-amazon
ylwu-amzn
approved these changes
Oct 20, 2020
kaituo
reviewed
Oct 20, 2020
| @@ -23,7 +23,7 @@ | |||
| public class ADResultBulkAction extends ActionType<BulkResponse> { | |||
|
|
|||
| public static final ADResultBulkAction INSTANCE = new ADResultBulkAction(); | |||
| //Internal Action which is not used for public facing RestAPIs. | |||
| // Internal Action which is not used for public facing RestAPIs. | |||
| public static final String NAME = "cluster:admin/opendistro/adinternal/write/bulk"; | |||
There was a problem hiding this comment.
Could we put the internal and external action common prefix to CommonValue so that it is harder to have typo errors and easier to maintain in case that we want to change in the future?
There was a problem hiding this comment.
Sure, thats a nice idea.
Will make a change.
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| public class AnomalyResultAction extends ActionType<AnomalyResultResponse> { | |||
| public static final AnomalyResultAction INSTANCE = new AnomalyResultAction(); | |||
| //External Action which used for public facing RestAPIs. | |||
| // External Action which used for public facing RestAPIs. | |||
There was a problem hiding this comment.
should this be internal since only background job runs it?
There was a problem hiding this comment.
It is also used in one of our Rest APIs which I wanted it to be external action :
kaituo
reviewed
Oct 21, 2020
| import org.elasticsearch.action.ActionType; | ||
|
|
||
| public class DeleteModelAction extends ActionType<DeleteModelResponse> { | ||
| public static final DeleteModelAction INSTANCE = new DeleteModelAction(); | ||
| // Internal Action which is not used for public facing RestAPIs. | ||
| public static final String NAME = "cluster:admin/opendistro/adinternal/model/delete"; | ||
| public static final String NAME = CommonValue.EXTERNAL_ACTION_PREFIX + "model/delete"; |
There was a problem hiding this comment.
Yeah I did take care of it : )
kaituo
approved these changes
Oct 21, 2020
|
This is breaking tests. |
Reordered INSTANCE and NAME statements to fix them, thanks @kaituo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #195 *
Description of changes:
Renaming all actions to distinguish between Internal facing vs external facing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.