Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix for get detector API #290

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

kaituo
Copy link
Member

@kaituo kaituo commented Oct 23, 2020

Issue #, if available:

Description of changes:

We didn't return after sending back channel responses after one recent change. Later, when we use the channel to send back responses again, we get " java.lang.IllegalStateException: Channel is already closed". This PR fixes this issue.

This PR also removes a redundant setting.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

We didn't return after sending back channel responses after one recent change.  Later, when we use the channel to send back responses again, we get " java.lang.IllegalStateException: Channel is already closed".  This PR fixes this issue.

This PR also removes an redundant setting.
@kaituo kaituo added the bug Something isn't working label Oct 23, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #290 into master will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #290      +/-   ##
============================================
- Coverage     71.39%   71.29%   -0.11%     
  Complexity     1871     1871              
============================================
  Files           195      195              
  Lines          9020     9018       -2     
  Branches        764      764              
============================================
- Hits           6440     6429      -11     
- Misses         2215     2224       +9     
  Partials        365      365              
Flag Coverage Δ Complexity Δ
#cli 79.27% <ø> (ø) 0.00 <ø> (ø)
#plugin 70.59% <100.00%> (-0.12%) 1871.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...stroforelasticsearch/ad/AnomalyDetectorPlugin.java 93.44% <ø> (ø) 13.00 <0.00> (ø)
...ticsearch/ad/settings/AnomalyDetectorSettings.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...d/transport/GetAnomalyDetectorTransportAction.java 44.32% <100.00%> (-2.55%) 9.00 <0.00> (ø)
...port/SearchAnomalyDetectorInfoTransportAction.java 54.54% <0.00%> (-9.10%) 4.00% <0.00%> (ø%)
...ransport/DeleteAnomalyDetectorTransportAction.java 57.95% <0.00%> (-2.28%) 16.00% <0.00%> (ø%)

@kaituo kaituo merged commit d1c54e5 into opendistro-for-elasticsearch:master Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants