Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Change AD indices to be hidden indices instead of system indices. #394

Commits on Mar 6, 2021

  1. Change AD indices to be hidden indices instead of system indices.

    Previously, we registered AD indices as system indices as AD indices' names start with a dot. ES deprecates the creation of dot-prefixed index names except for hidden and system indices (elastic/elasticsearch#49959). Starting 7.10, ES adds a dedicated thread pool for system index write operations. System index writes/reads have higher priority than user index writes/reads. For example, system index writes can be forced regardless of whether the current index pressure is high or not (https://github.com/elastic/elasticsearch/blob/242083a36e02496aae9214dc41b89372022e7076/server/src/main/java/org/elasticsearch/index/IndexingPressure.java#L62-L73). 
    
    AD indices are not more important than other user indices. We don't want AD index reads/writes to impact user indices' reads/writes. This PR removes AD indices out of the system index list and marks them hidden indices instead.
    
    This change does not impact created AD indices. They are still system indices. Newly created AD indices will be hidden instead of system indices. This change won't impact search/index API. To list hidden indices, one can use localhost:9200/_cat/indices?v&expand_wildcards=all
    
    Testing done:
    1. Ran backward-compatibility tests. After updating AD, old detectors run fine, and we can create/run new detectors. All public APIs still work.
    ylwu-amzn authored and kaituo committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    e753b58 View commit details
    Browse the repository at this point in the history