This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Change AD indices to be hidden indices instead of system indices #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a forward-port of PR 394, 395. Testing done: 1. Manually verified AD indices are hidden.
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
=========================================
Coverage 79.16% 79.17%
- Complexity 2680 2682 +2
=========================================
Files 248 248
Lines 11749 11749
Branches 1010 1010
=========================================
+ Hits 9301 9302 +1
Misses 1970 1970
+ Partials 478 477 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
yizheliu-amazon
approved these changes
Mar 10, 2021
| @@ -4,10 +4,12 @@ on: | |||
| branches: | |||
| - main | |||
| - opendistro-* | |||
| - 7.10.2-no-workbench | |||
There was a problem hiding this comment.
we may not need this in main branch.
ylwu-amzn
approved these changes
Mar 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This is a forward-port of PR 394, 395.
Testing done:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.