Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Cypress with security #165

Merged
merged 5 commits into from Mar 18, 2021
Merged

Cypress with security #165

merged 5 commits into from Mar 18, 2021

Conversation

bowenlan-amzn
Copy link
Contributor

@bowenlan-amzn bowenlan-amzn commented Mar 18, 2021

Issue #, if available:

Description of changes:
This PR enable IM kibana plugin to run cypress with security: yarn run cypress open --env security_enabled=true
It also stablize the test, previously there are always some test failing in github action.

For cypress with security plugin, since we haven't integrate security with IM plugin, once we integrated, these cypress test will need further updated, like we cannot directly modify the managed-index start_time by updating .opendistro-ism-config which gonna be a system index.

Thanks to @tlfeng cypress change for alerting plugin

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Copy link
Contributor

@tlfeng tlfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and it's amazing you fixed the flaky test! 🎉

@bowenlan-amzn bowenlan-amzn merged commit 57a4336 into main Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants