This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
odfe 1.8 version upgrade #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazanec15
reviewed
May 19, 2020
| @@ -8,7 +8,7 @@ jobs: | |||
| build: | |||
| strategy: | |||
| matrix: | |||
| java: [13] | |||
| java: [14] | |||
There was a problem hiding this comment.
Need to update in other 2 Github actions as well
| violationRules { | ||
| rule { | ||
| limit { | ||
| minimum = 0.5 |
There was a problem hiding this comment.
Might be worth adding a comment about test coverage in the ReadMe.
There was a problem hiding this comment.
Not sure if coverage needs to be added to README. Seems ok to me.
There was a problem hiding this comment.
Yes, probably not necessary.
Done sanity with multi nodes. Also ran |
jmazanec15
approved these changes
May 19, 2020
| violationRules { | ||
| rule { | ||
| limit { | ||
| minimum = 0.5 |
There was a problem hiding this comment.
Yes, probably not necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#113
Description of changes:
ODFE 1.8 support with Elasticsearch oss version 7.7.0
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.