This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
added github action to build library artifacts #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamshin
reviewed
Jun 5, 2020
.github/workflows/CD.yml
Outdated
| @@ -29,7 +30,24 @@ jobs: | |||
| with: | |||
| java-version: ${{ matrix.java }} | |||
|
|
|||
| - name: Run build | |||
| - name: Build library | |||
There was a problem hiding this comment.
Nit: Should we call it "Build library artifacts"?
There was a problem hiding this comment.
You are right. Because they also send artifacts to S3, I changed name to Build and ship library artifacts
weicongs-amazon
approved these changes
Jun 5, 2020
chenqi0805
added a commit
to chenqi0805/k-NN
that referenced
this pull request
Jun 9, 2020
* master: added github action to build library artifacts (opendistro-for-elasticsearch#132) FIX: buildDir->rootDir Build separate artifacts for library using CPack (opendistro-for-elasticsearch#123) Fix test structure (opendistro-for-elasticsearch#125)
vamshin
pushed a commit
that referenced
this pull request
Jun 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#122
Description of changes:
Added job in CD workflow to build DEB and RPM artifacts and copy them to S3.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.