Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add default index settings when parsing index #205

Conversation

jmazanec15
Copy link
Member

Issue #, if available:
#204

Description of changes:
Adds in default settings if an exception is thrown when attempting to get settings for the index during parsing. More details on why this is needed in the issue.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmazanec15 jmazanec15 added bug Issue that exposes a bug Bug Fixes Change that fixes a bug and removed bug Issue that exposes a bug labels Sep 1, 2020
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #205 into master will increase coverage by 0.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #205      +/-   ##
============================================
+ Coverage     76.44%   76.95%   +0.51%     
- Complexity      301      302       +1     
============================================
  Files            50       50              
  Lines          1163     1189      +26     
  Branches        100      100              
============================================
+ Hits            889      915      +26     
  Misses          225      225              
  Partials         49       49              
Impacted Files Coverage Δ Complexity Δ
...ndistroforelasticsearch/knn/index/KNNSettings.java 83.47% <100.00%> (+1.48%) 27.00 <0.00> (ø)
...relasticsearch/knn/index/KNNVectorFieldMapper.java 77.85% <100.00%> (+2.85%) 15.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e29139b...a9fbfec. Read the comment docs.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fixes Change that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants