Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Update default variable settings name #209

Conversation

jmazanec15
Copy link
Member

Issue #, if available:

Description of changes:
Update default variable settings name

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmazanec15 jmazanec15 added the Refactoring A change intended to improve the design, structure, and/or implementation while preserving function label Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #209 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #209   +/-   ##
=========================================
  Coverage     76.95%   76.95%           
  Complexity      302      302           
=========================================
  Files            50       50           
  Lines          1189     1189           
  Branches        100      100           
=========================================
  Hits            915      915           
  Misses          225      225           
  Partials         49       49           
Impacted Files Coverage Δ Complexity Δ
...ndistroforelasticsearch/knn/index/KNNSettings.java 83.47% <100.00%> (ø) 27.00 <0.00> (ø)
...relasticsearch/knn/index/KNNVectorFieldMapper.java 77.85% <100.00%> (ø) 15.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d86167...f554670. Read the comment docs.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmazanec15 jmazanec15 merged commit f71bc1b into opendistro-for-elasticsearch:master Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Refactoring A change intended to improve the design, structure, and/or implementation while preserving function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants