Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Change CD workflow to use new staging bucket for artifacts #301

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Jan 12, 2021

Description of changes:
The infrastructure team is separating the production and staging locations into different AWS accounts. Plugins need to modify their workflows to publish to the new locations.

This PR changes the CD workflow to add a build number and write the zip, deb, and rpm plugin artifacts to staging.artifacts.opendistroforelasticsearch.amazon.com.

Test Result: https://github.com/opendistro-for-elasticsearch/k-NN/runs/1685141609?check_suite_focus=true

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gaiksaya gaiksaya changed the title [WIP] Change release workflow to use new staging bucket for artifacts [WIP] Change CD workflow to use new staging bucket for artifacts Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #301 (8685bf4) into master (79f7748) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #301   +/-   ##
=========================================
  Coverage     80.51%   80.51%           
  Complexity      388      388           
=========================================
  Files            62       62           
  Lines          1468     1468           
  Branches        130      130           
=========================================
  Hits           1182     1182           
  Misses          239      239           
  Partials         47       47           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79f7748...8685bf4. Read the comment docs.

@gaiksaya gaiksaya marked this pull request as draft January 12, 2021 18:28
@gaiksaya gaiksaya marked this pull request as ready for review February 1, 2021 21:50
@gaiksaya gaiksaya changed the title [WIP] Change CD workflow to use new staging bucket for artifacts Change CD workflow to use new staging bucket for artifacts Feb 1, 2021
@gaiksaya gaiksaya requested review from jmazanec15, a team and VijayanB and removed request for jmazanec15 February 1, 2021 21:51
@peterzhuamazon peterzhuamazon requested review from jmazanec15 and removed request for a team and VijayanB February 1, 2021 21:57
Copy link
Member

@jmazanec15 jmazanec15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmazanec15 jmazanec15 requested review from vamshin and VijayanB and removed request for vamshin February 1, 2021 22:02
@VijayanB
Copy link
Member

VijayanB commented Feb 1, 2021

LGTM

@jmazanec15 jmazanec15 added the Infrastructure Change releated to distribution of plugin label Feb 1, 2021
@jmazanec15 jmazanec15 merged commit 570a937 into master Feb 1, 2021
@gaiksaya gaiksaya deleted the release-workflow-patch branch February 1, 2021 22:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Infrastructure Change releated to distribution of plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants